Fix issue with progress bar panic on download #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where if the cache sends a `permission denied` error, the next download tries to utilize the completed bar and panic. Now on failure it calls abort and removes the bar instance.
|
@jhiemstrawisc I think this fixes the issue you were encountering however, I am having trouble recreating the issue so I kept this as a draft for now until tested. Do you want to give this fix a try and see if it looks right? |
jhiemstrawisc
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
@joereuss12, of course, since the errors I was getting were transient in the first place, I can't seem to recreate them either with or without your additions here. Your changes look sensible and don't seem to cause any new errors, though, so let's fly with them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where if the cache sends a
permission deniederror, the next download tries to utilize the completed bar and panic. Now on failure it calls abort and removes the bar instance.